114 IteratorNext(JSContext *cx, uintN argc, jsval *vp) this should be void (see FinishCreatingIterator): 153 JS_SetReservedSlot(cx, obj, 1, INT_TO_JSVAL(idx)); 282 FinishCreatingIterator(JSContext *cx, JSObject *iterObj, JSBool keysonly) 295 if (!JS_SetReservedSlot(cx, iterObj, 0, PRIVATE_TO_JSVAL(ida)) || 296 !JS_SetReservedSlot(cx, iterObj, 1, JSVAL_ZERO) || 297 !JS_SetReservedSlot(cx, iterObj, 2, BOOLEAN_TO_JSVAL(keysonly))) { 298 return nsnull; this should be optimizable by checking for slot 2, and then unconditionally performing (void) sets for 0 and 1 380 CreateSimpleIterator(JSContext *cx, JSObject *scope, JSBool keysonly, 391 if (!JS_SetReservedSlot(cx, iterObj, 0, PRIVATE_TO_JSVAL(nsnull)) || 392 !JS_SetReservedSlot(cx, iterObj, 1, JSVAL_ZERO) || 393 !JS_SetReservedSlot(cx, iterObj, 2, JSVAL_TRUE)) { ibid. 502 NewResolve(JSContext *cx, JSObject *wrapperObj, JSBool wantDetails, 523 if (!::JS_GetReservedSlot(cx, wrapperObj, sFlagsSlot, &oldFlags) || 524 !::JS_SetReservedSlot(cx, wrapperObj, sFlagsSlot, this can be safely (void): 533 JS_SetReservedSlot(cx, wrapperObj, sFlagsSlot, oldFlags); 543 ResolveNativeProperty(JSContext *cx, JSObject *wrapperObj, 559 if (!::JS_GetReservedSlot(cx, wrapperObj, sFlagsSlot, &oldFlags) || 560 !::JS_SetReservedSlot(cx, wrapperObj, sFlagsSlot, this should be (void): 583 if (!::JS_SetReservedSlot(cx, wrapperObj, sFlagsSlot, oldFlags)) { 584 return JS_FALSE; 543 ResolveNativeProperty(JSContext *cx, JSObject *wrapperObj, 720 if (!isNativeWrapper && 721 (!::JS_GetReservedSlot(cx, wrapperObj, sFlagsSlot, &oldFlags) || 722 !::JS_SetReservedSlot(cx, wrapperObj, sFlagsSlot, 725 return JS_FALSE; 734 if (!isNativeWrapper && this should be (void): 735 !::JS_SetReservedSlot(cx, wrapperObj, sFlagsSlot, oldFlags)) {

this is a minor update to proposal

This code went away with compartments.